Fix #9775: Fix primitive-in-condition handling in backend #9827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isPrimitive/getPrimitive are overloaded: they both have a version which takes a symbol as input and a version which takes a tree, the latter can handle array get and set primitives which map to different JVM instructions depending on their type, but we don't care about that when emitting conditions in genCond: we only need to look for primitives which correspond to boolean operations and those are already handled by the symbol versions of isPrimitive/getPrimitive. By using these methods in genCond we avoid running some unnecessary code and we fix scala#9775 which was triggered because the `getPrimitive` overload we were using required forcing `lhs`. This change also aligns us with what the scalac backend does.
nicolasstucki
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isPrimitive/getPrimitive are overloaded: they both have a version which
takes a symbol as input and a version which takes a tree, the latter can
handle array get and set primitives which map to different JVM
instructions depending on their type, but we don't care about that when
emitting conditions in genCond: we only need to look for primitives
which correspond to boolean operations and those are already handled by
the symbol versions of isPrimitive/getPrimitive. By using these methods
in genCond we avoid running some unnecessary code and we fix #9775 which
was triggered because the
getPrimitiveoverload we were using requiredforcing
lhs. This change also aligns us with what the scalac backenddoes.